Repository navigation
T&A 48420: Fix Manual Scoring Null Sequence - #12179
Open
aaronbidzan wants to merge 2 commits into
Open
aaronbidzan wants to merge 2 commits into
aaronbidzan wants to merge 2 commits into
Conversation
See: https://mantis.ilias.de/view.php?id=48420 Opening the Manual Scoring tab sorted questions by `getPlaceInSequence()`. Random tests never attach sequence information, so that call ran on null and the tab ended in a whoops. A random question set has no shared sequence, so the sort is skipped there. Fixed tests still sort by place in sequence, and only after the empty-list return.
dsstrassner
approved these changes
Oct 7, 2026
dsstrassner
left a comment
dsstrassner
left a comment
Contributor
There was a problem hiding this comment.
I tested this locally, and now the manual scoring works again with random question selection. Thanks, @aaronbidzan, for the prompt fix.
Obviously I can't say if the other code authorities are agreeing with the code changes. Or if they preferred another way 😁
Contributor
|
Hey @dsstrassner, I discussed internally with @aaronbidzan whether we could move the sorting logic into the repository function itself, so that the list of questions is returned in the correct order. We are currently checking whether this could introduce any side effects. If not, @aaronbidzan will provide a small update, and I can proceed with the merge. Kind regards, |
See: https://mantis.ilias.de/view.php?id=48420 Manual Scoring and the questions table both sorted a test's questions by place in sequence. `buildQuestionPropertiesForFixedTest()` now returns that order, with question ids kept as keys. Random tests are unchanged because they have no shared sequence. The two consumer sorts are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48420
Opening the Manual Scoring tab sorted questions by
getPlaceInSequence(). Random tests never attach sequence information, so that call ran on null and the tab ended in a whoops. A random question set has no shared sequence, so the sort is skipped there. Fixed tests still sort by place in sequence, and only after the empty-list return.Kind regards,
@aaronbidzan
/cc @thojou