Skip to content

UI-Component: fix null value input-handling for group in group #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iszmais wants to merge 1 commit into
base: release_11
Choose a base branch
from
+4 −1
Open

UI-Component: fix null value input-handling for group in group #11869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/ILIAS/UI/src/Implementation/Component/Input/Group.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function getValue()
*/
public function withValue($value): self
{
$this->checkArg("value", null === $value || $this->isClientSideValueOk($value), "Display value does not match input type.");
$this->checkArg("value", $this->isClientSideValueOk($value), "Display value does not match input type.");
$clone = clone $this;
foreach ($this->getInputs() as $k => $i) {
// note isClientSideValueOk() verifies the structure, there
Expand Down Expand Up @@ -132,6 +132,9 @@ protected function nameInputs(NameSource $source, string $parent_name): array
*/
protected function _isClientSideValueOk($value): bool
{
if ($value === null) {
return true;
}
if (!is_array($value)) {
return false;
}
Expand Down
Loading