Skip to content

[FIX] #48172: Fix video playback issue occuring on apple safari #11867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mBeym wants to merge 1 commit into
base: release_10
Choose a base branch
from
+7 −2
Open

[FIX] #48172: Fix video playback issue occuring on apple safari #11867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions components/ILIAS/FileDelivery/classes/FileDeliveryTypes/PHPChunked.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ public function deliver(string $path_to_file, bool $file_marked_to_delete): void
* (mediatype = mimetype)
* as well as a boundry header to indicate the various chunks of data.
*/
$response = $this->httpService->response()->withHeader("Accept-Ranges", "0-$length");
$response = $this->httpService->response()->withHeader(ResponseHeader::ACCEPT_RANGES, 'bytes');
Comment thread
mBeym marked this conversation as resolved.
$this->httpService->saveResponse($response);
$server = $this->httpService->request()->getServerParams();
$is_partial = false;
// header('Accept-Ranges: bytes');
// multipart/byteranges
// http://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.2
Expand Down Expand Up @@ -161,14 +162,18 @@ public function deliver(string $path_to_file, bool $file_marked_to_delete): void
$end = $c_end;
$length = $end - $start + 1; // Calculate new content length
fseek($fp, (int) $start);
$is_partial = true;

$response = $this->httpService->response()->withStatus(206);

$this->httpService->saveResponse($response);
} // fim do if

// Notify the client the byte range we'll be outputting
$response = $this->httpService->response()->withHeader(ResponseHeader::CONTENT_RANGE, "bytes $start-$end/$size")->withHeader(ResponseHeader::CONTENT_LENGTH, $length);
$response = $this->httpService->response()->withHeader(ResponseHeader::CONTENT_LENGTH, (string) $length);
if ($is_partial) {
$response = $response->withHeader(ResponseHeader::CONTENT_RANGE, "bytes $start-$end/$size");
}

$this->httpService->saveResponse($response);

Expand Down
Loading