Skip to content

Fixing the CodeSystem temporarily#43

Open
jkiddo wants to merge 1 commit into
IHE:masterfrom
trifork:dcmuid-fix
Open

Fixing the CodeSystem temporarily#43
jkiddo wants to merge 1 commit into
IHE:masterfrom
trifork:dcmuid-fix

Conversation

@jkiddo

@jkiddo jkiddo commented Jun 9, 2026

Copy link
Copy Markdown

📑 Description

This pull request introduces significant improvements to the handling of DICOM UID codes in the IHE FormatCode vocabulary implementation. The main change is the replacement of the previous non-expandable reference to the DICOM ontology with a new, locally defined, computable FHIR CodeSystem for DICOM UIDs. This enables proper expansion and validation of the ValueSet, particularly for the XDS-I KOS FormatCode. Additionally, the build scripts for both Windows (_build.bat) and Unix (_build.sh) have been modernized and unified, improving usability and maintainability.

The most important changes are:

FHIR Terminology Improvements:

  • Introduced a new FHIR CodeSystem resource (codesystem-dicom-uid.xml) that enumerates the DICOM UID(s) referenced by the FormatCode ValueSet, enabling expansion and validation. This replaces the previous non-expandable external reference.
  • Updated the ValueSet/formatcode resource to reference the new local CodeSystem (http://ihe.net/fhir/ihe.formatcode.fhir/CodeSystem/dicom-uid) instead of the DICOM RDF/OWL ontology, and added explanatory comments.
  • Registered the new CodeSystem as a resource and as a special-url in the IG definition (implementationguide-IHE.FormatCode.xml). [1] [2]
  • Updated ignoreWarnings.txt to remove now-unnecessary warning suppressions for the DICOM UID code system, with explanatory comments about the change.

Build Script Modernization:

  • Rewrote both _build.bat (Windows) and _build.sh (Unix) scripts for greater robustness, feature parity, and improved user interaction. The scripts now provide consistent options for downloading/updating the publisher, building the IG, running Jekyll, and cleaning up, with better handling of publisher location and online/offline status. [1] [2]
  • Improved the network connectivity check in _updatePublisher.bat to use PowerShell for reliability, matching the approach in the new build scripts.

Closes #

✅ Checks

  • [ X] My pull request adheres to the code style of this project
  • [ X] My code requires changes to the documentation
  • [ X] I have updated the documentation as required
  • [ X] All the tests have passed
  • [ X] I have selected a committee co-chair to review the PR ( @oliveregger looking at you 👀 )

ℹ Additional Information

@jkiddo

jkiddo commented Jun 9, 2026

Copy link
Copy Markdown
Author

@mattblackmon as discussed 👆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant