Fixing the CodeSystem temporarily#43
Open
jkiddo wants to merge 1 commit into
Open
Conversation
Author
|
@mattblackmon as discussed 👆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
This pull request introduces significant improvements to the handling of DICOM UID codes in the IHE FormatCode vocabulary implementation. The main change is the replacement of the previous non-expandable reference to the DICOM ontology with a new, locally defined, computable FHIR
CodeSystemfor DICOM UIDs. This enables proper expansion and validation of the ValueSet, particularly for the XDS-I KOS FormatCode. Additionally, the build scripts for both Windows (_build.bat) and Unix (_build.sh) have been modernized and unified, improving usability and maintainability.The most important changes are:
FHIR Terminology Improvements:
CodeSystemresource (codesystem-dicom-uid.xml) that enumerates the DICOM UID(s) referenced by the FormatCode ValueSet, enabling expansion and validation. This replaces the previous non-expandable external reference.ValueSet/formatcoderesource to reference the new localCodeSystem(http://ihe.net/fhir/ihe.formatcode.fhir/CodeSystem/dicom-uid) instead of the DICOM RDF/OWL ontology, and added explanatory comments.special-urlin the IG definition (implementationguide-IHE.FormatCode.xml). [1] [2]ignoreWarnings.txtto remove now-unnecessary warning suppressions for the DICOM UID code system, with explanatory comments about the change.Build Script Modernization:
_build.bat(Windows) and_build.sh(Unix) scripts for greater robustness, feature parity, and improved user interaction. The scripts now provide consistent options for downloading/updating the publisher, building the IG, running Jekyll, and cleaning up, with better handling of publisher location and online/offline status. [1] [2]_updatePublisher.batto use PowerShell for reliability, matching the approach in the new build scripts.Closes #
✅ Checks
ℹ Additional Information