Skip to content

fix(logging-view): resolve four logging view issues (#601, #602, #603, #604) - #606

Merged
JavierRibaldelRio merged 6 commits into
developfrom
logging-view/fix-david-issues
Aug 3, 2026
Merged

fix(logging-view): resolve four logging view issues (#601, #602, #603, #604)#606
JavierRibaldelRio merged 6 commits into
developfrom
logging-view/fix-david-issues

Conversation

@JavierRibaldelRio

@JavierRibaldelRio JavierRibaldelRio commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the four open <Logging-View> issues filed by @davidpascual05:

  • <Logging-View> Logo does not appear in PNG image when autoscale is applied #601 — Logo missing from PNG export when autoscale is applied. Root cause: the plot's Plotly modebar had two "download as PNG" affordances — the app's own header Export PNG button (always renders in the light/print theme with the Hyperloop logo watermark) and Plotly's own built-in "Download plot as a PNG" camera-icon button (snapshots the raw on-screen dark canvas, no branding, ever). The built-in button sits right next to Autoscale/Reset axes in the modebar, so a user who'd just clicked Autoscale would often reach for it instead of the dedicated header button — producing an unbranded export that had nothing to do with autoscale itself. Fix: removed the built-in button (modeBarButtonsToRemove: [..., "toImage"]) so there's a single, always-branded PNG export path. Verified with a real headless-browser repro before and after the fix.
  • <Logging-View> On-screen message when adding a new plot #602 — No on-screen indication when a new plot is added. Added a transient "Plot N added" toast (mirrors the existing SessionStatusToast styling/auto-dismiss pattern), triggered centrally from addStudioPlot so every entry point (toolbar, sidebar, per-series "New Plot") is covered.
  • <Logging-View> The table of contents does not contain links #603 — Table of contents doesn't link to plots. This turned out to be about the exported PDF report's Table of Contents page, not the in-app sidebar (which I also made clickable as a small bonus, see below) — its entries were plain text with no way to jump to the corresponding chart page. Each entry (and its page number) is now a real internal jsPDF link to that chart's page; verified against an actual export (link annotations with distinct /Dest page targets, one per plot).
  • <Logging-View> Button to lock a plot #604 — Button to lock a plot. Added a per-plot lock toggle (header button + context-menu item). Locking a plot sets fixedrange on all its axes (Plotly's native mechanism — this also makes Plotly hide the now-useless zoom/pan modebar entirely) and disables drag-to-resize, inline rename, and signal drag-and-drop onto that plot, so its view can't be changed by accident. Hover/tooltips keep working.

Bonus (not a reported issue, but a natural companion to #603): each plot's name in the in-app right-panel "Plots" list is now also a link that scrolls the corresponding plot into view in the main area.

Test plan

All fixes were manually verified end-to-end against the real app (synthetic CSV session, headless Chromium via Playwright), not just type-checked:

- Remove Plotly's built-in "Download plot as a PNG" modebar button, which
  exported the raw dark on-screen canvas with no Hyperloop branding — the
  header's own "Export PNG" button already produces a properly themed,
  branded export, so two competing PNG-export paths on the same toolbar was
  the actual cause of the "logo missing" reports (#601).
- Show a toast confirmation when a new plot is added (#602).
- Make each plot's name in the right-panel "Plots" list a link that scrolls
  the corresponding plot into view (#603).
- Add a per-plot lock toggle that freezes pan/zoom/scroll-zoom (via Plotly's
  fixedrange), and disables drag-to-resize, inline rename and signal drops,
  so the view can't be changed by accident (#604).
@JavierRibaldelRio JavierRibaldelRio changed the title fix(logging-view): resolve four Plot Studio issues (#601, #602, #603, #604) fix(logging-view): resolve four logging view issues (#601, #602, #603, #604) Aug 3, 2026
@JavierRibaldelRio
JavierRibaldelRio marked this pull request as ready for review August 3, 2026 16:26
#603 was about the exported PDF's Table of Contents page, not the app's
sidebar plot list — its entries were plain text with no way to jump to
the corresponding chart page. Each entry (and its page number) is now
an internal jsPDF link to that chart's page, verified against a real
export (link annotations with distinct /Dest page targets, one per plot).
Closing a session (the X in the Session sidebar group) reset session
metadata but left every plot, loaded CSV signal, and composed operation/
transform from that session sitting in the store — dangling references
to data that no longer existed. clearSession now also resets studioPlots,
studioFiles, studioOperations and studioTransforms.
Was top-right, inconsistent with the newer plot-added toast — moved to
the same bottom-right corner/style so both read as one toast stack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant