fix(build): align Tauri CLI with Rust runtime - #216
Conversation
Reviewer's GuideThis PR updates the Tauri CLI dev dependency to match the Rust runtime version and moves pnpm-specific configuration from package.json into pnpm-workspace.yaml, aligning build tooling and workspace settings with pnpm’s recommended structure. Flow diagram for pnpm workspace overrides and allowBuilds resolutionflowchart TD
A["pnpm install in workspace"] --> B["Read pnpm-workspace.yaml"]
B --> C["Apply overrides for workspace packages"]
C --> D["Check allowBuilds flags"]
D -->|true| E["Build allowed dependencies (core-js, esbuild, msw)"]
D -->|false| F["Skip builds for disallowed deps (@j178/prek, sharp, workerd)"]
E --> G["Complete install with workspace-aligned tooling"]
F --> G
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
📦 Semifold release planPlan calculated through commit 527a64b. Changesets introduced by this pull request: 1 changesets · 1 packages
This comment updates automatically as the pull request changes. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that overrides are applied at the workspace level, consider verifying whether any package previously relied on different local overrides and, if so, document or adjust those to avoid unexpected resolution changes.
- The new allowBuilds configuration introduces explicit build controls; you may want to audit other build-time dependencies across packages to ensure they are correctly classified so that pnpm doesn’t skip necessary builds or perform unnecessary ones.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that overrides are applied at the workspace level, consider verifying whether any package previously relied on different local overrides and, if so, document or adjust those to avoid unexpected resolution changes.
- The new allowBuilds configuration introduces explicit build controls; you may want to audit other build-time dependencies across packages to ensure they are correctly classified so that pnpm doesn’t skip necessary builds or perform unnecessary ones.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
339d531 to
37d7f9e
Compare
There was a problem hiding this comment.
Pull request overview
Aligns the repo’s JavaScript workspace configuration for newer pnpm/Tauri tooling by moving pnpm settings into pnpm-workspace.yaml and bumping the Tauri CLI dependency.
Changes:
- Move pnpm dependency overrides from
package.jsontopnpm-workspace.yaml(workspace-level). - Replace the prior
onlyBuiltDependenciesconfig with anallowBuildsallow/deny list inpnpm-workspace.yaml. - Update
@tauri-apps/clito^2.11.4and refreshpnpm-lock.yamlaccordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds workspace-level pnpm overrides and build-allowlisting configuration. |
| pnpm-lock.yaml | Updates lockfile to reflect the new overrides/config and the Tauri CLI version bump. |
| package.json | Removes packageManager, removes embedded pnpm config, and bumps @tauri-apps/cli. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary by Sourcery
Align the Tauri toolchain and workspace dependency management to ensure consistent builds and updater-compatible Linux packages.
Bug Fixes:
Enhancements:
Build:
CI:
Documentation:
Chores: