workflows/tests: replace alls-green with a conclusion job#1006
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
There was a problem hiding this comment.
Pull request overview
This PR removes the third-party re-actors/alls-green GitHub Action from the CI workflow and replaces it with a first-party shell-based “conclusion” job that enforces the final tests matrix result.
Changes:
- Replaced the aggregate
checkjob (third-party action) with a shell-basedconclusionjob. - Added an explicit assertion step that fails the workflow when
needs.tests.resultis notsuccess.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Jul 18, 2026
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Thanks! Would be good to replace as many third-party actions as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-actors/alls-greenis a third-party action. Replace the aggregatecheckjob with a shell-basedconclusionjob that asserts thetestsmatrix result, matchingpatchelf.rbandHomebrew/.github.