feat: add continuation diagnostics - #8
Merged
Merged
Conversation
HisenWeb
marked this pull request as ready for review
June 24, 2026 23:24
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds P1-4 diagnostics around Codex tool-result continuation and stored-state recovery.
This is logging/documentation-only. It does not change protocol behavior, state lookup rules, fallback behavior, or Responses output shape.
Changes
stateless_tool_history_bypass_state_lookupwhen full stateless history bypasses stored-state lookup.stored_response_not_foundwhen a requested stored response ID is missing from non-expired state.tool_history_unique_fallback_hitwhen continuation is recovered via unique pendingcall_idfallback.tool_history_call_id_ambiguousandtool_history_response_ambiguouswhen fallback is refused due ambiguity.tool_history_call_id_not_foundwhen fallback cannot match all requested call IDs.docs/p1-continuation-diagnostics.mdwith event names and operational interpretation.Validation
Edited via GitHub connector. Please run locally before merge:
Notes
I intentionally avoided modifying
server.rs; diagnostics were added in the narrow conversion/state layers that own the relevant decisions.