fix(onboarding): intake sharing saves on one tap + auto-saves on edit (43)#89
Merged
Merged
Conversation
… (43) The reported bug: on a sensitive section, "share with partner all" popped a confirm that REPLACED the picker, so clicking Save without first clicking "Share it" silently lost the choice; and sharing only ever persisted via the Save button. - One tap, no confirm: applyScope/applyBulk apply directly (a sensitive answer still STARTS Private, so sharing is still an explicit choice). Removed pendingShare/renderConfirm. - Auto-save on edit: a new silent autoSaveForm + a debounced effect persists answer + sharing changes immediately on a COMPLETED section; the button becomes "Done". First-time sections keep the explicit Continue (auto-save never completes a section being filled the first time). 855 desktop unit (3 reworked RTL: one-tap+auto-save per-question, bulk share-all [the bug], first-time-doesn't-auto-save) + E2E (re-open complete basics → widen to +Sibling → persists with no Save click). Synced spec 43. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the reported bug: in onboarding (e.g. Intimacy & sexuality), clicking "share with partner all" then Save didn't persist.
Root cause (diagnosed, not assumed)
Intake sharing was written only by the "Save changes" button. On a sensitive section, the bulk "share all" didn't apply on the pick — it popped an inline confirm that replaced the picker, so clicking Save without first clicking "Share it" silently dropped the choice and Save persisted the old (Private) scopes. The single-scope
intake:setAnswerSharingchannel existed but the form never called it.The fix (per your two decisions)
pendingShare/renderConfirmmachinery.autoSaveForm+ a debounced (600ms) effect persists answer & sharing changes the instant they happen, on a section you've already completed (i.e. are editing). The button becomes "Done". A first-time section is unchanged — it keeps the explicit Continue (which is what marks it complete; auto-save never completes a section being filled the first time, so no premature portrait).Verification
🤖 Generated with Claude Code