fix(auth): render PIN dots as SVG circles (reliable on real iOS)#116
Merged
Conversation
Styled HTML elements (empty spans, then solid divs) for the PIN dots rendered in desktop Chromium and WebKit but vanished on a real iPhone in Safari, even on the live deploy with no caching involved. Replace them with an inline <svg> of <circle>s — SVG shapes render identically on every device. The svg is decorative (aria-hidden) with a visually-hidden <output> live region preserving the "N of 4 digits entered" announcement. Verified the circles render in WebKit and the PIN e2e still passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PIN dots rendered in desktop Chromium and WebKit but vanished on a real iPhone in Safari — on the live deploy, with
no-storeHTML and content-hashed CSS, so not caching/URL/engine. Styled empty HTML elements were the problem. Replace them with an inline<svg>of<circle>s, which render identically on every device. SVG is decorative (aria-hidden) with a visually-hidden<output>live region for the count. Verified circles render in WebKit and the PIN e2e passes.🤖 Generated with Claude Code