fix(auth): make empty PIN dots unmistakable + verify on a production build#110
Merged
Conversation
The empty PIN slots used a faint 2px hairline (--color-text-faint, ~4.6:1) that could still read as "no dots" on a real device. Switch to a filled circle (--color-surface-strong) with a bright --color-text-muted ring (~7:1), 18px, and reserve the row height so the dot area never collapses. Verified the rule ships in the production webpack build and renders four visible dots both empty and after a wrong-PIN clear. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty PIN slots used a faint hairline ring (
--color-text-faint, ~4.6:1) which could still read as "no dots" — and, critically, I'd only ever verified on a dev server, not a production build.--color-text-mutedring (~7:1), 18px, and the row reserves its height so the dot area can't collapse.next build(webpack, same as Vercel): the rule ships in the built CSS bundle, and the rendered pad shows 4 visible dots both empty and right after a wrong-PIN clear (computed: bgrgb(18,53,40), border2px rgb(159,205,187)).Note: a user reported still seeing no dots in their installed PWA. The deployed code does render dots (confirmed above), so that's the service worker serving cached pre-fix CSS — this bolder change + the new deploy (SW
skipWaiting/clientsClaim) should resolve it on reload.🤖 Generated with Claude Code