Repository navigation
Fix: Render Chinese and Japanese characters on invoice PDFs - #1384
Merged
Merged
Conversation
* Fix: Render Chinese and Japanese characters on invoice PDFs Invoices were rendered with DejaVu Sans only, which has no CJK glyphs, so Chinese names, addresses, event titles and translated labels showed as empty boxes. - Bundle Noto Sans SC (Regular/Bold, OFL) and add it after DejaVu Sans in the invoice font stack; dompdf falls back per character - Enable font subsetting (invoices drop from ~880 KB to ~25-50 KB) - Use bold instead of weight 500 for info values, which fell back to Times and could not render CJK - Route both invoice PDF paths through InvoicePdfRenderer, which skips the CJK font and logs a warning when the dompdf font cache is not writable, so invoices never fail to render * Run the unwritable font cache test in-process so CI stderr logging can't fail it
|
🚅 Deployed to the Hi.Events-pr-1384 environment in Hi.Events
1 service not affected by this PR
|
railway-app
Bot
temporarily deployed
to
Hi.Events / Hi.Events-pr-1384
October 11, 2026 12:27
Destroyed
Contributor
|
| ✅ Passed | ❌ Failed | ⏭️ Skipped | ⏱️ Duration | |
|---|---|---|---|---|
| 95 | 0 | 1 | 0 | 2m 57s |
Flaky (passed on retry)
⚠️ organizer/organizer-management.spec.ts— organizer management › an organizer creates a second organizer from the global menu
daveearley
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes I've made
Why I've made these changes
How I've tested these changes
Checklist