You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Config exclude globs were recorded as skipped but still indexed, because walkDirectory continued only the inner pattern loop. Matching files (and stale failed-batch retries for those paths) are now omitted from the index.
Changes
Skip files as soon as an exclude glob matches in collectFiles / walkDirectory, instead of falling through to include matching.
Skip walking directories covered by /** exclude globs (for example **/common/**).
Drop stale failed-batch retries for newly excluded paths on incremental /index and retryFailedBatches.
Document the behavior and add unit/indexer coverage.
Testing
How were these changes tested?
Unit tests added/updated
Manual testing performed
Build passes (npm run build)
Typecheck passes (npm run typecheck)
Tests pass (npm run test:run)
Lint passes (npm run lint)
Release Labels
Added at least one release category label (feature, bug, performance, documentation, dependencies, refactor, test, chore, or skip-changelog)
Added at most one semver label (semver:major, semver:minor, or semver:patch) when needed
isStoredPathExcluded() now checks the absolute storedPath against config globs before normalizing project-owned paths relative to the project (src/indexer/index.ts:1268-1271). In global scope, the default **/.*/** can match a hidden parent directory such as /Users/me/.work/project, so valid failed batches are silently discarded instead of retried.
Please normalize project-owned absolute paths before glob matching, then add coverage for a project beneath a hidden directory. I verified the regression: the PR fails 5 affected failed-batch cases, while main passes 28/28 in the same setup. Build, CLI smoke test, native build, typecheck, and lint pass.
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the current head 38d5bdb: the hidden-parent failed-batch retry regression is covered, all hosted CI checks are green, and no inline review comments are outstanding. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config
excludeglobs were recorded as skipped but still indexed, becausewalkDirectorycontinued only the inner pattern loop. Matching files (and stale failed-batch retries for those paths) are now omitted from the index.Changes
excludeglob matches incollectFiles/walkDirectory, instead of falling through to include matching./**exclude globs (for example**/common/**)./indexandretryFailedBatches.Testing
How were these changes tested?
npm run build)npm run typecheck)npm run test:run)npm run lint)Release Labels
feature,bug,performance,documentation,dependencies,refactor,test,chore, orskip-changelog)semver:major,semver:minor, orsemver:patch) when neededLabels:
bugRelated Issues
No tracked issue.