Skip to content

fix(ui): close menu dropdowns on outside click and Esc, add an X to Recent - #566

Open
angela-helios wants to merge 1 commit into
mainfrom
fix/menu-dropdown-close
Open

fix(ui): close menu dropdowns on outside click and Esc, add an X to Recent#566
angela-helios wants to merge 1 commit into
mainfrom
fix/menu-dropdown-close

Conversation

@angela-helios

Copy link
Copy Markdown
Contributor

The Recent-searches popup on Search / Saved Queries only closed by re-clicking its toggle (or by picking an entry). Manual testing flagged that it should also close on an outside click and from an explicit control.

What changed

Tests

  • Extended the existing queries-page render test to assert the close control ships (data-addbox-close).
  • cargo test -p helios-ui --lib: 67 passed.
  • Exercised manually: outside click, Esc, and the X on the Recent popup; outside click and Esc on the tenant and version menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant