Skip to content

Allow HistogramLogReader to read file objects#58

Draft
Mirochill wants to merge 1 commit into
HdrHistogram:masterfrom
Mirochill:fix-28-logreader-file-object
Draft

Allow HistogramLogReader to read file objects#58
Mirochill wants to merge 1 commit into
HdrHistogram:masterfrom
Mirochill:fix-28-logreader-file-object

Conversation

@Mirochill

Copy link
Copy Markdown

Summary:

  • Allow HistogramLogReader to accept either a path or a file-like object with readline().
  • Decode byte lines as UTF-8 so binary handles, including zipfile.open(), can be read directly.
  • Keep caller-owned file objects open when HistogramLogReader.close() is called, and add a regression test for that behavior.

Fixes #28.

Validation:

  • Not run locally.

@ahothan

ahothan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Just curious what motivates you to submit so many PRs on so many git repositories @Mirochill ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: HistogramLogReader accepts already open files

2 participants