Skip to content

[tools] Fix case handling when checking options changes #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobil4sk wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[tools] Fix case handling when checking options changes #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
582af19
[tools] Detect upper case HXCPP flag changes
tobil4sk Oct 31, 2026
6ba4bf5
[tools] Fix casing in options flag filtering
tobil4sk Oct 31, 2026
cc293bf
[tests] Check rebuild with HXCPP_DEBUGGER
tobil4sk Oct 31, 2026
f134c95
[tools] Remove redundant option exclusion
tobil4sk Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/tools/rebuild-debugger/Main.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
function main() {}
2 changes: 2 additions & 0 deletions test/tools/rebuild-debugger/build-0-no-debugger.hxml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-m Main
--cpp bin
3 changes: 3 additions & 0 deletions test/tools/rebuild-debugger/build-1-debugger.hxml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-m Main
--cpp bin
-D HXCPP_DEBUGGER
12 changes: 6 additions & 6 deletions tools/hxcpp/FileGroup.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,18 +204,18 @@ class FileGroup
var result = new Array<String>();
for(def in contents.split("\n"))
{
var name = def.split("=")[0];//.toLowerCase();
if (name.indexOf("hxcpp_link")>=0)
var name = def.split("=")[0];
if (name.indexOf("HXCPP_LINK")>=0)
{
// Only effects linking, not compiling
}
else if (name=="hxcpp_verbose" || name=="hxcpp_silent" || name=="hxcpp_quiet" || name=="hxcpp_times" || name=="hxcpp_neko_buildtool" || name=="hxcpp_link_no_tool_depends" )
else if (name=="HXCPP_VERBOSE" || name=="HXCPP_SILENT" || name=="HXCPP_QUIET" || name=="HXCPP_TIMES" || name=="HXCPP_NEKO_BUILDTOOL")
{
// Does not affect build
}
else if (name.indexOf("hxcpp")>=0 || name=="scriptable" || name.indexOf("dll")>=0 || name=="no_console" ||
name.substr(0,8)=="android-" || name.substr(0,4)=="ndkv" || name=="toolchain" || name=="platform" ||
name=="toolchain_version" || name=="android_ndk_root" )
else if (name.indexOf("hxcpp")>=0 || name.indexOf("HXCPP")>=0 || name=="scriptable" || name.indexOf("dll")>=0 || name=="no_console" ||
name.substr(0,8)=="android-" || name.substr(0,4)=="NDKV" || name=="toolchain" || name=="PLATFORM" ||
name=="TOOLCHAIN_VERSION" || name=="ANDROID_NDK_ROOT" )
result.push(def);
}

Expand Down
Loading