Repository navigation
Fix Utf16::codepoint linking on modern gcc - #1451
Merged
Aidan63 merged 1 commit intoOct 31, 2026
Merged
Conversation
It looks like in (at least) gcc 15+, the inline allows for the function definition to be omitted from linking altogether. This causes linking errors if another file calls it, as is the case in TestUtf16 in the native tests. We didn't see this in ci before because it was using ubuntu 24.04, which ran gcc 13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in (at least) gcc 15+, the inline allows for the function definition to be omitted from linking altogether. This causes linking errors if another file calls it, as is the case in TestUtf16 in the native tests.
We didn't see this in ci before because it was using ubuntu 24.04, which ran gcc 13.
I did this in #1306 in an attempt to improve performance, but I guess it is not valid if other translation units can't see the inline definition. EDIT: I think this is the relevant part of the standard:
https://github.com/cplusplus/draft/blob/d4d6f38143c1b495aa33b2e5de0e0ec2daa173ca/source/declarations.tex#L1140-L1144