Repository navigation
Fix stale library objects when flags change - #1450
Merged
Merged
Conversation
Paves the way for more tools tests
The libraries may need to be recompiled as some flags in Options.txt affect whether functions in hxcpp.h are inline. In the case of hxcpp_regexp, hxcpp_smart_strings affects whether it will use pcre2-16 symbols.
import changes the relative directory, which means Options.txt is no longer relative to the original Build.xml. include doesn't change it, so we can use it instead.
Previously, compiling hxcpp_regexp once with smart strings and again without would lead to a stale RegExp.o that still referenced pcre2-16 symbols. This test ensures it is now working properly, since hxcpp_regexp now tracks Options.txt changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if you rebuild a project that uses RegExp with
-D disable-unicode-strings, you don't get linking errors due to RegExp.o being stale. This is demonstrated with the test. It should also apply to other flags. This closes #922.The fix is adapted from #1420.