Skip to content

feat(pstack): sync portable workflows and selected Codex fork additions - #3

Merged
HashemKhalifa merged 8 commits into
mainfrom
feat/classified-pstack-sync
Oct 7, 2026
Merged

HashemKhalifa merged 8 commits into
mainfrom
feat/classified-pstack-sync

Conversation

@HashemKhalifa

@HashemKhalifa HashemKhalifa commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Why

Sync portable pstack 0.14.5 → 0.15.5 improvements and selected workflows while preserving Codex-native live model enumeration, parent inheritance, all five agents, and read-only reviewer permissions.

Scope

  • Expand to 53 skills with two upstream principles and six selected fork additions.
  • Strengthen revision-bound verification, fair benchmarks, bottom-first stack shipping, append-only trails, explicit worktree isolation, and native plan paths.
  • Add read-only worktree auditing and executable regression coverage.
  • Prepare release 1.1.0.

SYNC.md lists affected files and behavior. UPSTREAM.json classifies all 104 changed source paths.

Tradeoffs

Exclude the loopback bridge and Benny ledger because they introduce separate services and state without a demonstrated requirement. Preserve native setup instead of the fork's hardcoded models, global role document, and two-agent installer.

Verification

  • Structural validation: 53 skills and five unchanged agent definitions.
  • 15 Python tests, 52 bundled helper tests, 17 Node behavior tests, and strict helper typechecking.
  • Pinned inventory matches all 104 source paths.
  • All five fresh native spawn-and-wait probes pass on Codex CLI 0.159.3.
  • Semantic-release dry-run calculates and verifies 1.1.0.
  • Native plan-review findings were fixed and rechecked.
  • Both GitHub review findings were reproduced with failing tests, then fixed: rename-safe NUL-delimited path records and current-only smoke roster validation that preserves historical evidence.

Validation details distinguish the tested runtime SHA from later test and validation-helper commits. The live smoke receipt records every role.

Plugin activation follows merge, installation/update, and a fresh Codex task.

The latest review's placeholder false positives were reproduced and fixed with regression coverage for generics, HTML, and autolinks. Live validation covers the CLI; Codex desktop plugin discovery and native agent spawning remain unverified.

Follow-up review fixes name the scaffold file field explicitly to avoid SVG tag collisions and replace Cursor liveness/restart assumptions with available native collaboration state and ownership reconciliation. These documentation changes do not imply completed desktop-app validation.

@HashemKhalifa
HashemKhalifa marked this pull request as ready for review October 7, 2026 09:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T10:09:59.686415Z 910fd79 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95080a173a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/pstack-codex/scripts/check_upstream.py Outdated
Comment thread plugins/pstack-codex/scripts/validate_port.py Outdated
@HashemKhalifa

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8644e3319c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/pstack-codex/skills/poteto-mode/scripts/check-plan.mjs Outdated
@HashemKhalifa

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62f342e7c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/pstack-codex/skills/poteto-mode/scripts/check-plan.mjs
Comment thread plugins/pstack-codex/skills/poteto-mode/playbooks/orchestrate.md Outdated
@HashemKhalifa

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 910fd791cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/pstack-codex/skills/no-comments/SKILL.md Outdated
@HashemKhalifa
HashemKhalifa merged commit 5d74be1 into main Oct 7, 2026
1 check passed
@HashemKhalifa
HashemKhalifa deleted the feat/classified-pstack-sync branch October 7, 2026 12:28
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant