Repository navigation
Drop the unused OpenTelemetry dependencies - #4
Closed
Harshith029 wants to merge 1 commit into
Closed
Harshith029 wants to merge 1 commit into
Harshith029 wants to merge 1 commit into
Conversation
Trace and span ids come from `secrets`, and nothing under src/ imports opentelemetry or azure.monitor any more, yet pyproject still required azure-monitor-opentelemetry, opentelemetry-api and opentelemetry-sdk. Removed them, and the 28 versions.lock pins that only they reached: the Azure Monitor exporter, azure-core-tracing-opentelemetry, the OpenTelemetry instrumentation and support packages, msrest, oauthlib, requests-oauthlib, psutil, wrapt, asgiref, importlib_metadata and zipp. Reachability was computed from the installed metadata, evaluating markers for Python 3.11 and 3.12 on Linux, Windows and macOS; every remaining pin is still reached. Verified in a fresh Python 3.11 venv built from the lock, with no OpenTelemetry installed: ruff, mypy --strict and the full suite (594 passed, 1 known xfail); scripts/check_versions_lock.py reports 0 conflicts; the wheel installs with -c versions.lock and `sentinel --help` runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3. Review and merge that first; GitHub then retargets this PR to
main.Nothing in
src/importsopentelemetryorazure.monitorany more, now that trace and span ids come fromsecrets(#3).pyproject.tomlstill required three OpenTelemetry packages, though.Changes
pyproject.toml: removesazure-monitor-opentelemetry,opentelemetry-api,opentelemetry-sdk, and the OpenTelemetry warning filter.versions.lock: removes 28 pins (104 → 76): the three above, plus 25 packages that only they needed:azure-core-tracing-opentelemetrymsrest,oauthlib,requests-oauthlib,psutil,wrapt,asgiref,importlib_metadata,zippI worked out which pins could go from the installed packages' metadata, evaluating version and platform conditions for Python 3.11 and 3.12 on Linux, Windows and macOS. Every remaining pin is still needed by something.
Also updated: the smoke test's required-pin list, the README credits, and a "Removed" entry in the CHANGELOG.
Testing
All in a fresh Python 3.11 venv built from the lock, with no OpenTelemetry installed:
mypy --strict: clean.scripts/check_versions_lock.py: 0 conflicts.-c versions.lock, andsentinel --helpruns.This machine has no Python 3.12, so the 3.12 leg is CI's.
🤖 Generated with Claude Code