Skip to content

fix: try a different pagination ux#1249

Open
cb1kenobi wants to merge 1 commit into
stagefrom
different-pagination
Open

fix: try a different pagination ux#1249
cb1kenobi wants to merge 1 commit into
stagefrom
different-pagination

Conversation

@cb1kenobi

Copy link
Copy Markdown
Member

I feel the pagination UX could be improved. I added individual page buttons, cleaned up the labels, last page is always visible in pagination, and centered the pagination. I don't love this as the pagination jumps around as you click through the pages.

I'm looking to start a conversation and get some feedback. Feel free to close this if this is a bad idea.

Before:

image

After:

image image image

@cb1kenobi cb1kenobi requested a review from a team as a code owner June 15, 2026 22:30
@cb1kenobi cb1kenobi requested a review from dawsontoth June 15, 2026 22:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the TableView component by extracting its inline pagination markup and logic into a dedicated, reusable TablePagination component. This simplifies TableView.tsx and removes several unused imports and callback definitions. I have no feedback to provide on these changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant