Skip to content

fix: table list scroll, make result set header sticky#1248

Open
cb1kenobi wants to merge 2 commits into
stagefrom
fix-ui-scrolling
Open

fix: table list scroll, make result set header sticky#1248
cb1kenobi wants to merge 2 commits into
stagefrom
fix-ui-scrolling

Conversation

@cb1kenobi

Copy link
Copy Markdown
Member

If you have many tables, you need to scroll the entire browser window to scroll the list of tables. This PR restricts the height of the sidebar to the browser window's height and will automatically show the scrollbar if the list of tables exceeds the height of the browser window.

A nice side effect of this, it fixes the mismatched background color behind the "Create a Table" button.

It also makes the result set table header sticky so you can see the column names as you scroll.

This does not make the Add new Record, Import CSV, etc elements sticky. It also doesn't make the pagination in the footer sticky. Only the table header.

@cb1kenobi cb1kenobi requested a review from a team as a code owner June 15, 2026 20:04
@cb1kenobi cb1kenobi requested a review from dawsontoth June 15, 2026 20:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the database view layout to support sticky headers and a sticky sidebar using Tailwind CSS. The review feedback points out syntax errors in Tailwind v4 spacing variables (using parentheses instead of hyphens) in both ColumnFilters.tsx and index.tsx. Additionally, there is a concern that changing the table container to overflow-visible in TableView.tsx will disable horizontal scrolling for wide tables.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/features/instance/databases/components/ColumnFilters.tsx
Comment thread src/features/instance/databases/index.tsx
Comment thread src/features/instance/databases/components/TableView.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant