fix: Detect when permissions are dirty#1247
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a memoized initialPermissions state to track whether organization role permissions have been modified, updating the 'Save Changes' button's disabled state accordingly. Feedback points out a critical state synchronization issue where updatedPermissions will not update when roleInfo changes because the modal remains mounted, and suggests syncing state during render. Additionally, it is recommended to change the Monaco Editor's prop from defaultValue to value to ensure updates are correctly reflected in the editor.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.