Skip to content

fix: Detect when permissions are dirty#1247

Merged
dawsontoth merged 2 commits into
stagefrom
fix-role-dirty-check
Jun 15, 2026
Merged

fix: Detect when permissions are dirty#1247
dawsontoth merged 2 commits into
stagefrom
fix-role-dirty-check

Conversation

@dawsontoth

Copy link
Copy Markdown
Contributor

No description provided.

@dawsontoth dawsontoth requested a review from a team as a code owner June 15, 2026 18:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a memoized initialPermissions state to track whether organization role permissions have been modified, updating the 'Save Changes' button's disabled state accordingly. Feedback points out a critical state synchronization issue where updatedPermissions will not update when roleInfo changes because the modal remains mounted, and suggests syncing state during render. Additionally, it is recommended to change the Monaco Editor's prop from defaultValue to value to ensure updates are correctly reflected in the editor.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@dawsontoth dawsontoth merged commit b5781d8 into stage Jun 15, 2026
2 checks passed
@dawsontoth dawsontoth deleted the fix-role-dirty-check branch June 15, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant