Skip to content

fix: Render markdown with better fidelity#1246

Merged
dawsontoth merged 2 commits into
stagefrom
markdown-renderer-color-improvements
Jun 15, 2026
Merged

fix: Render markdown with better fidelity#1246
dawsontoth merged 2 commits into
stagefrom
markdown-renderer-color-improvements

Conversation

@dawsontoth

Copy link
Copy Markdown
Contributor

No description provided.

@dawsontoth dawsontoth requested a review from a team as a code owner June 15, 2026 16:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CSS styles for the directory README component to support both light and dark themes properly, utilizing CSS variables for colors and borders, and adding specific dark mode overrides for code blocks and table zebra striping. The review feedback suggests removing a redundant text color declaration in the dark mode override for code blocks, as the parent selector's CSS variable already dynamically resolves to the correct foreground color.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/features/instance/applications/components/directoryReadMe.css
dawsontoth and others added 2 commits June 15, 2026 12:50
The dark code-block override only needed to change the background; the text color falls through to the parent code rule's var(--foreground), which already resolves to near-white in dark mode. Addresses Gemini review feedback on #1246.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dawsontoth dawsontoth force-pushed the markdown-renderer-color-improvements branch from 9ec1bb7 to c92309c Compare June 15, 2026 16:50
@dawsontoth dawsontoth merged commit 236aab9 into stage Jun 15, 2026
2 checks passed
@dawsontoth dawsontoth deleted the markdown-renderer-color-improvements branch June 15, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant