Skip to content

kits: cell citations read as links; a value axis's labels fit the panel - #48

Merged
richard-epsilla merged 2 commits into
mainfrom
fix/cell-links-axis-labels
Oct 19, 2026
Merged

richard-epsilla merged 2 commits into
mainfrom
fix/cell-links-axis-labels

Conversation

@richard-epsilla

Copy link
Copy Markdown
Contributor

Two display fixes found in end-to-end kit runs on staging (2026-10-19).

Sheets: citations in a cell read as links. An agent cell keeps its inline Markdown citations by design (cellAnswer), but the grid showed them raw: "Zero-ops hybrid retrieval for AI apps ([docs.trychroma.com]…". linkParts (lib/answer.js) splits a value into text and link parts. Each [text](address) with an http or https address is drawn as a small link named by its text. It opens in a new tab (noopener noreferrer) and doesn't select the cell. Any other address (javascript:, mailto:, relative) stays text exactly as written. Nothing is set with dangerouslySetInnerHTML. The stored value and the export are unchanged.

Dashboards: value axis labels fit the panel. A horizontal bar chart's value axis ended on "18,000,0". ECharts centres the last label on the axis end, and half of a long label hangs past the grid's right margin, which containLabel doesn't count. In chartOption:

  • a value axis with no formatter of its own gets compact ticks (18M, 1.2K; values under a thousand as written);
  • a horizontal value axis ends its last label at the axis end (alignMaxLabel: 'right', ECharts 5.6);
  • the grid holds its labels unless the chart set the grid.

A formatter, alignment or grid the chart wrote is always kept.

Tests (node --test; the new ones failed on main because the exports didn't exist):

  • sheets answer.test.mjs: 11 to 15. A link becomes a link part; a non-http address stays text; plain or empty values; parentheses in an address; two links.
  • dashboard dashboard.test.mjs: 28 to 33. Horizontal and vertical value axes; the chart's own formatter and alignment kept; several axes; grid kept when the chart set it.
  • Whole npm test: sheets 56 to 60, dashboard 47 to 52. The same 1 and 2 files fail on main in a clone without node_modules, because reifyui isn't installed.

🤖 Generated with Claude Code

richard-epsilla and others added 2 commits October 19, 2026 06:27
…s raw Markdown

An agent cell keeps its inline citations by design, and the grid showed them as written:
"Zero-ops hybrid retrieval for AI apps ([docs.trychroma.com]..." (staging, 2026-10-19). Each inline
link with an http or https address is now drawn as a small link named by its text, opening in a new
tab (noopener, noreferrer) without selecting the cell; any other address stays text. The stored
value and the export are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er runs past the edge

A horizontal bar chart's value axis ended on "18,000,0" (RNA sequences per database, staging,
2026-10-19): ECharts centres the last label on the axis end and half of a long label hangs past the
grid's right margin, which containLabel does not count. A value axis with no formatter of its own
now gets compact ticks (18M, 1.2K; small numbers as written), a horizontal one ends its last label
at the axis end (alignMaxLabel), and the grid holds its labels unless the chart set the grid. A
formatter, alignment or grid the chart wrote is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@richard-epsilla
richard-epsilla merged commit 65cc392 into main Oct 19, 2026
10 checks passed
@richard-epsilla
richard-epsilla deleted the fix/cell-links-axis-labels branch October 19, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant