Repository navigation
kits: cell citations read as links; a value axis's labels fit the panel - #48
Merged
Merged
Conversation
…s raw Markdown An agent cell keeps its inline citations by design, and the grid showed them as written: "Zero-ops hybrid retrieval for AI apps ([docs.trychroma.com]..." (staging, 2026-10-19). Each inline link with an http or https address is now drawn as a small link named by its text, opening in a new tab (noopener, noreferrer) without selecting the cell; any other address stays text. The stored value and the export are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er runs past the edge A horizontal bar chart's value axis ended on "18,000,0" (RNA sequences per database, staging, 2026-10-19): ECharts centres the last label on the axis end and half of a long label hangs past the grid's right margin, which containLabel does not count. A value axis with no formatter of its own now gets compact ticks (18M, 1.2K; small numbers as written), a horizontal one ends its last label at the axis end (alignMaxLabel), and the grid holds its labels unless the chart set the grid. A formatter, alignment or grid the chart wrote is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two display fixes found in end-to-end kit runs on staging (2026-10-19).
Sheets: citations in a cell read as links. An agent cell keeps its inline Markdown citations by design (
cellAnswer), but the grid showed them raw: "Zero-ops hybrid retrieval for AI apps ([docs.trychroma.com]…".linkParts(lib/answer.js) splits a value into text and link parts. Each[text](address)with an http or https address is drawn as a small link named by its text. It opens in a new tab (noopener noreferrer) and doesn't select the cell. Any other address (javascript:, mailto:, relative) stays text exactly as written. Nothing is set withdangerouslySetInnerHTML. The stored value and the export are unchanged.Dashboards: value axis labels fit the panel. A horizontal bar chart's value axis ended on "18,000,0". ECharts centres the last label on the axis end, and half of a long label hangs past the grid's right margin, which
containLabeldoesn't count. InchartOption:alignMaxLabel: 'right', ECharts 5.6);A formatter, alignment or grid the chart wrote is always kept.
Tests (node --test; the new ones failed on main because the exports didn't exist):
answer.test.mjs: 11 to 15. A link becomes a link part; a non-http address stays text; plain or empty values; parentheses in an address; two links.dashboard.test.mjs: 28 to 33. Horizontal and vertical value axes; the chart's own formatter and alignment kept; several axes; grid kept when the chart set it.npm test: sheets 56 to 60, dashboard 47 to 52. The same 1 and 2 files fail on main in a clone withoutnode_modules, becausereifyuiisn't installed.🤖 Generated with Claude Code