Repository navigation
Add --min-saving to structpad suggest - #5
Merged
Merged
Conversation
Made by a BAKED bench run (round 100).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by gulliby
Before
structpad suggestprinted a block for every struct, also for a struct that is packed already or saves only a few bytes.After
structpad suggest --min-saving Nprints only the structs whose suggested order saves at least N bytes. N is a whole number with 1 to 6 digits, checked like the value of--max-padding. The default is 0, so without the option nothing changes. A struct that saves exactly N is kept. When every struct is left out, the output isno struct saves at least N bytesand the exit status is 0.layoutandcheckrefuse the option.How
src/structpad/cli.py: the option, its value check and the refusal in the other commands.src/structpad/render.py: the filter and the empty-result line.tests/test_min_saving.pyhas 23 new tests.tests/test_cli.pyandtests/test_readme.pychange for the usage text.README.md: the usage block and the description ofsuggest.ruff check .is clean.Made by a BAKED bench run (round 100, sdd workflow, run e6b9835d).
🤖 Generated with Claude Code