Repository navigation
fix(make): add the local-test target the docs point to - #174
Merged
Merged
Conversation
rennf93
added
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md:82,CLAUDE.md:74,100,220andAGENTS.md:75,101,221tell people to runmake local-test, but the Makefile had no such target (make local-testfailed with "No rule to make target"). This adds it, the same target flaskapi-guard, djapi-guard and tornadoapi-guard already have.REDIS_URLdefaults toredis://localhost:6379, the default the tests already use (tests/conftest.py:59). SetREDIS_URLto point it somewhere else, or rundocker compose up -d redisif Redis isn't installed.[tool.pytest.ini_options]addopts (--cov=guard --cov-branch --cov-report=term-missing).Verified on macOS, Python 3.10.22, against a throwaway
redis-serveron 127.0.0.1:16399:make install-dev: exit 0REDIS_URL=redis://localhost:16399 make local-test: exit 0, 487 passed,guardat 100% statements and branchesenv -u REDIS_URL make -n local-testexpands toREDIS_URL=${REDIS_URL:-redis://localhost:6379} uv run pytest -v --cov=guard --cov-report=term-missingMakefile only. No code or test changes.