Skip saving a {null:1b} to disk when serializing a null field - #5286
Open
screret wants to merge 3 commits into
Open
Skip saving a {null:1b} to disk when serializing a null field#5286screret wants to merge 3 commits into
{null:1b} to disk when serializing a null field#5286screret wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
save a small amount of users' disk space by not serializing the null marker NBT tags sync uses to signal clients that the field is null (instead of unchanged)
Implementation Details
Check if we're sending/receiving sync data and only serialize the null field markers if so
AI Usage
Outcome
smaller region data files
How Was This Tested
inspected an existing machine with
/data get block x y z(notice many{null:1b}compound tags)Switched to this PR's branch
did the same, no more of those