Skip to content

Clean up nullability within material system - #5253

Open
gustovafing wants to merge 17 commits into
1.20.1from
gus/remove-null-material
Open

Clean up nullability within material system#5253
gustovafing wants to merge 17 commits into
1.20.1from
gus/remove-null-material

Conversation

@gustovafing

@gustovafing gustovafing commented Aug 6, 2026

Copy link
Copy Markdown
Member

What

Cleans up the handling of null materials and values within the material system.

  • Removes the null material, replacing usages with null
  • Removes the null tag prefix, replacing usages with null
  • Requires all elements of a material entry to be non-null

@github-actions github-actions Bot added the 1.20.1 label Aug 6, 2026
@gustovafing gustovafing added type: refactor Suggestion to refactor a section of code Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release labels Aug 6, 2026
@github-actions github-actions Bot added the Tests: Failed Game Tests have failed on this PR label Aug 6, 2026
YoungOnionMC
YoungOnionMC requested changes Aug 6, 2026
View reviewed changes
Comment thread src/main/java/com/gregtechceu/gtceu/api/block/PipeBlock.java
Comment thread src/main/java/com/gregtechceu/gtceu/api/block/SimpleCoilType.java
Comment thread src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/properties/IngotProperty.java
Comment thread src/main/java/com/gregtechceu/gtceu/api/data/worldgen/generator/VeinGenerator.java
@gustovafing
Merge branch '1.20.1' into gus/remove-null-material
c72b26e 
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/block/MaterialBlock.java
@gustovafing
fix
8014e55
@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Aug 6, 2026
@gustovafing
gustovafing marked this pull request as ready for review August 10, 2026 06:27
@gustovafing
gustovafing requested a review from a team as a code owner August 10, 2026 06:27
@gustovafing
spotless
85bd4fe
@gustovafing
review fixes
9ee0e7f
@gustovafing
Merge branch '1.20.1' into gus/remove-null-material
a5ca8a5 
# Conflicts:
#	docs/content/Modpacks/Changes/v8.0.0.md
#	src/main/java/com/gregtechceu/gtceu/common/data/GTMaterials.java
@github-actions github-actions Bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Aug 15, 2026
@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Aug 15, 2026
jurrejelle
jurrejelle reviewed Aug 15, 2026
View reviewed changes
Comment thread src/main/java/com/gregtechceu/gtceu/api/data/chemical/ChemicalHelper.java
}
}
return MaterialEntry.NULL_ENTRY;
return null;

@jurrejelle jurrejelle Aug 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@gustovafing gustovafing Aug 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@github-actions github-actions Bot added Tests: Failed Game Tests have failed on this PR Tests: Passed Game Tests have passed on this PR and removed Tests: Passed Game Tests have passed on this PR Tests: Failed Game Tests have failed on this PR labels Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jurrejelle jurrejelle jurrejelle left review comments
@YoungOnionMC YoungOnionMC YoungOnionMC approved these changes
+1 more reviewer
@screret screret screret left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

1.20.1 Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gustovafing @jurrejelle @YoungOnionMC @screret