Clean up dynamic data injection - #5250
Open
screret wants to merge 20 commits into
Open
Conversation
somebody-a forgot to merge half of GregTechCEu#3981. not having it broke reloading.
…ay it to only happen when recipes are parsed so we have a more complete registry context [^1]: from the mixins it used to reside in
it's an internal class, so this is fine!
…al casey this time
…ausing a warning to be logged
…al = true)` on the old ones
Is this Mojank? maybe
screret
force-pushed
the
sc/clean-up-dynamic-data-injection
branch
from
August 7, 2026 15:00
69c610c to
aa1c3a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
So it's not all in MixinHelpers.
Implementation Details
This PR is based on #5244, so that should be merged first.
AI Usage
Outcome
wow, the code is way more readable now. who could've guessed putting it all into two functions was actually a bad idea.
How Was This Tested
Game still works the same as before I think
TODO test this. it's 11pm and I'm going to sleep now.
Additional Information
I renamed the tag addition methods TagPrefix has. I did add
@Deprecated(forRemoval = true)versions of the originals back, so no hard compatibility errors were added.TagType isn't API so it doesn't count.