Band-aid fix and run Datagen - #5214
Closed
DilithiumThoride wants to merge 2 commits into
Closed
Conversation
DilithiumThoride
added
1.21.1
type: bugfix
1 task
Contributor
Author
|
superceded by #5217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
1.21 datagen is broken, throwing Duplicate Lang Key errors.
Now at least it's runnable.
Implementation Details
I do not think this is the correct solution. I think the problem is something in
LangHandler.replace()but I have no idea where to look. Commenting these five keys out at least removes the duplicate key errors and lets datagen be run at all but this should be further examined by someone who understands the NeoForge datagen pipeline.Note that while the commit shows there are lang keys being removed, the lang for those 3 Oils does still exist just with oil_light flipped to light_oil, etc. The Oil and Creosote replace keys though, I don't know why those are even set to replace because they're already called Oil and Creosote.
AI Usage
Outcome
Datagen does run again