deferred registration help/materials - #5138
Open
screret wants to merge 7 commits into
Open
Conversation
…context available
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FLAWLESS DEFERRED REGISTRATION VICTORY
Implementation Details
a custom builder and entry type for materials so they're easier to work with.
AI Usage
Outcome
Material registration is now deferred via NeoForge
DeferredRegisters (and, of course, Registrate wrapping them).How Was This Tested
ran game -> main menu opens -> it works!
Additional Information
you cant get into a world because datagen is borked but it works!!
TODO:
MaterialEntryneeds a new name, they're conflicting rn.Potential Compatibility Issues
so much stuff lmao
P.S. I didn't run spotless.