-
Notifications
You must be signed in to change notification settings - Fork 0
feat: show file info in headerbar and add right-click copy menu #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+356
−38
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b25f0ce
feat: show file info in headerbar and add right-click copy menu
green2grey 32c0dea
chore: bump anyhow to 1.0.103 for RUSTSEC advisory
green2grey d46b4b5
fix: clear canvas on decode failure and present popover on allocate
green2grey 544231f
fix: address second-round review findings
green2grey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,6 @@ repo/ | |
| .claude/* | ||
| !.claude/CLAUDE.md | ||
|
|
||
| # Local working notes (not for the repo) | ||
| /TODO.local.md | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
ZoomableCanvasis a customgtk::Widgetwith no layout manager orsize_allocateimplementation, parenting aGtkPopoverMenuto it here is not enough for GTK to allocate and position that popover; custom popover parents need to present the popover during size allocation. In the new right-click path this means the context menu can be unallocated, misplaced, or fail to show. Add asize_allocatevfunc that presents the stored popover, or host it under a widget that already supports popover children.Useful? React with 👍 / 👎.