Skip to content

Add a 'Reverse Paths' node and pluralize 'Separate Paths' and 'Close Paths' - #4773

Merged
Keavon merged 3 commits into
masterfrom
separate-close-and-reverse-paths
Oct 21, 2026
Merged

Keavon merged 3 commits into
masterfrom
separate-close-and-reverse-paths

Conversation

@Keavon

@Keavon Keavon commented Oct 21, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Confidence score: 4/5

  • document_migration.rs can overwrite per-node Inspector input names and descriptions, losing custom metadata. Restrict replacement to known legacy values.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/portfolio/document_migration.rs">

<violation number="1" location="editor/src/messages/portfolio/document_migration.rs:2851">
P2: This migration overwrites customized input names and descriptions whenever they differ from the new defaults. Restrict the metadata replacement to the known legacy name/description values so per-node Inspector customizations survive the rename.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread editor/src/messages/portfolio/document_migration.rs
@Keavon
Keavon merged commit bdec449 into master Oct 21, 2026
11 checks passed
@Keavon
Keavon deleted the separate-close-and-reverse-paths branch October 21, 2026 20:03

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 3e17a777 Deployed Oct 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant