fix: inset settings icon below status bar after launch - #692
Open
xhon-pelushi wants to merge 1 commit into
Open
Conversation
The settings/quick-toggles button was pinned flush to the top edge of the screen, unlike the other top-row elements (main preview frame, QR-scan toggles) which already get pushed down by the system-bar inset in the same window-insets listener. That left the button directly under the area the transient system status bar overlay briefly occupies right after the app launches, making it hard to tap. Apply the same top margin used for the QR-scan toggles row so the settings icon clears that area too. Fixes GrapheneOS#589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the settings gear clear of the system status bar after launch by applying top inset margin (same pattern as qrScanToggles).
Fixes #589
Test plan