Repository navigation
fix: honor selected kube context and namespace overrides for deployments and cluster builds - #10194
Open
laurivosandi wants to merge 3 commits into
Open
laurivosandi wants to merge 3 commits into
laurivosandi wants to merge 3 commits into
Conversation
laurivosandi
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Skaffold’s kubectl CLI wrapper for namespace discovery in the run context and kubectl deployer. This ensures namespace lookups honor the selected Kubernetes context and kubeconfig.
Adds regression tests for context and kubeconfig selection, contexts without a namespace, and explicit namespace precedence.
User facing changes
Before: When selecting a different context or kubeconfig, Skaffold could resolve the namespace from kubectl’s current context instead.
After: Skaffold resolves the namespace from the selected context and kubeconfig. Explicit namespace overrides and configured default namespaces retain their existing precedence.