Repository navigation
docs(people-and-planet-ai): align wildlife notebook with updated clou… - #14763
Merged
Merged
Conversation
…d-sample-notebook standards Update people-and-planet-ai/image-classification/README.ipynb to adhere to the updated cloud-sample-notebook lifecycle and formatting guidelines while preserving the original Cell 0 ASF license header: - Use the 3-link launch badge bar (Colab, Colab Enterprise via /vertex-ai/colab/import/, and GitHub) and add the Author table. - Add Objectives, Costs (with Pricing Calculator link), and Prerequisites subsections under Overview. - Guard only !apt-get install libffi-dev behind google.colab and run the idempotent sparse-checkout unconditionally when not already inside people-and-planet-ai/image-classification. - Add # fmt: off / # fmt: on around @PARAM configuration blocks. - Add a 'Validate target state' programmatic assertion section before 'Cleaning up' and default delete_resources to False.
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the image classification README notebook by updating the Colab Enterprise import link, adding sections for objectives, costs, and prerequisites, and introducing a validation step for the target state. The feedback suggests a robust improvement to the validation step, recommending that the assertion checks the actual contents of the generated 'embeddings.jsonl' file rather than relying on in-memory variables.
…adge URL in wildlife notebook Restore https://console.cloud.google.com/agent-platform/colab/import/... as the Open in Colab Enterprise badge link in people-and-planet-ai/image-classification/README.ipynb.
… notebook and use patch.object
- Update the Validate target state cell in people-and-planet-ai/image-classification/README.ipynb
to read and parse embeddings.jsonl from disk and verify all 6 gallery rows (URI, species label,
and 768-dimensional embedding vector) rather than only checking in-memory variables.
- Replace raw string mock.patch("requests.get") with target-safe mock.patch.object in e2e_test.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d-sample-notebook standards
Update people-and-planet-ai/image-classification/README.ipynb to adhere to the updated cloud-sample-notebook lifecycle and formatting guidelines while preserving the original Cell 0 ASF license header:
Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions