Improve Firebase authentication and cookie handling - #14603
Open
vidhishav-sudo wants to merge 3 commits into
Open
vidhishav-sudo wants to merge 3 commits into
vidhishav-sudo wants to merge 3 commits into
Conversation
Fix Firebase Auth UI race condition in App Engine tutorial
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Firebase authentication flow in script.js by initializing the FirebaseUI Widget outside of onAuthStateChanged to prevent multiple instantiation errors, adding a callback to set the ID token cookie globally upon successful sign-in, and safely clearing the cookie on sign-out. The review feedback suggests adding a .catch() block to the getIdToken() promise to prevent the UI from hanging on failure, and explicitly setting the SameSite=Lax attribute when both setting and clearing the token cookie to enhance security against CSRF attacks.
…tatic/script.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…tatic/script.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Firebase Auth UI race condition in App Engine tutorial
Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions