Skip to content

deps: update dependencies in cloudbuild - #4445

Draft
angelcaamal wants to merge 1 commit into
mainfrom
deps-cloudbuild-update
Draft

deps: update dependencies in cloudbuild#4445
angelcaamal wants to merge 1 commit into
mainfrom
deps-cloudbuild-update

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/557360473
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: cloudbuild Issues related to the Cloud Build API. labels Sep 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies in package.json, including @google-cloud/cloudbuild, c8, and chai. The feedback highlights that upgrading chai to ^6.0.0 will break the tests because Chai v5+ is ESM-only, while the existing tests use CommonJS require statements. It is recommended to keep chai at ^4.x.

Comment thread cloudbuild/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudbuild Issues related to the Cloud Build API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant