Skip to content

mlengine: remove deprecated google_ml_engine_model for 8.0.0 - #18681

Open
c2thorn wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-google-ml-engine-model
Open

mlengine: remove deprecated google_ml_engine_model for 8.0.0#18681
c2thorn wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-google-ml-engine-model

Conversation

@c2thorn

@c2thorn c2thorn commented Aug 17, 2026

Copy link
Copy Markdown
Member

Remove the deprecated google_ml_engine_model resource and product for 8.0.0.

Fixes hashicorp/terraform-provider-google#22249

mlengine: removed deprecated `google_ml_engine_model` resource

@modular-magician

modular-magician commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6720873:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 4 insertions(+), 1377 deletions(-)
google-beta provider View Diff 13 files changed, 4 insertions(+), 1377 deletions(-)
terraform-google-conversion View Diff 3 files changed, 250 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_ml_engine_model was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

  • Error reading file website/docs/r/ml_engine_model.html.markdown

Test report

Analytics

Total Tests Passed Skipped Affected
6863 6142 693 28
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
  • TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange
  • TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
  • TestAccBigQueryDataset_basic
  • TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
  • TestAccBigQueryDataset_externalCatalogDatasetOptions_update
  • TestAccColabNotebookExecution_colabNotebookExecutionBasicExample
  • TestAccColabNotebookExecution_colabNotebookExecutionCustomEnvExample
  • TestAccColabNotebookExecution_colabNotebookExecutionDataformExample
  • TestAccColabNotebookExecution_colabNotebookExecutionFullExample
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSqlDatabaseInstance_performanceCaptureConfig
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
  • TestAccWorkbenchInstance_updateDeleteProtection
  • TestAccWorkbenchInstance_updateJupyterLab
  • TestAccWorkbenchInstance_updateMinCpuPlatform
  • TestAccWorkbenchInstance_updateResourcePolicies
  • TestAccWorkstationsWorkstationCluster_workstationClusterUrlsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_condition
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_nongcp_patterns
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log - TestAccAccessContextManager/service_perimeters_nongcp_patterns
✅ Log TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
✅ Log TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange
✅ Log TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
✅ Log TestAccBigQueryDataset_basic
✅ Log TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
✅ Log TestAccBigQueryDataset_externalCatalogDatasetOptions_update
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionBasicExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionCustomEnvExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionDataformExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionFullExample
✅ Log TestAccSqlDatabaseInstance_performanceCaptureConfig
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
✅ Log TestAccWorkbenchInstance_updateDeleteProtection
✅ Log TestAccWorkbenchInstance_updateJupyterLab
✅ Log TestAccWorkbenchInstance_updateMinCpuPlatform
✅ Log TestAccWorkbenchInstance_updateResourcePolicies
✅ Log TestAccWorkstationsWorkstationCluster_workstationClusterUrlsExample
✅ Log ❌ Error · Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log - TestAccAccessContextManager/gcp_user_access_binding
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for 6720873!

@c2thorn
c2thorn force-pushed the remove-google-ml-engine-model branch from 6720873 to c69d94f Compare August 17, 2026 22:58
@modular-magician

modular-magician commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c69d94f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 4 insertions(+), 1377 deletions(-)
google-beta provider View Diff 13 files changed, 4 insertions(+), 1377 deletions(-)
terraform-google-conversion View Diff 3 files changed, 250 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_ml_engine_model was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

  • Error reading file website/docs/r/ml_engine_model.html.markdown

Test report

Analytics

Total Tests Passed Skipped Affected
6879 6113 694 72
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 72 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
  • TestAccBigQueryDataset_basic
  • TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
  • TestAccBigQueryDataset_collationUpdate
  • TestAccBigQueryDataset_externalCatalogDatasetOptions_update
  • TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
  • TestAccCESTool_cesToolPythonFunctionBasicExample_update
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_MultiRegion
  • TestAccDataSourceGoogleBackupDRDataSourceReference_MultiRegion
  • TestAccDataSourceGoogleBackupDRDataSourceReference_basic
  • TestAccDataSourceGoogleBackupDRDataSourceReferences_basic
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccProjectServiceListResource_queryIdentity
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig
  • TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig
  • TestAccSqlDatabaseInstance_AutoUpgradeEnabled
  • TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize
  • TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize
  • TestAccSqlDatabaseInstance_Edition_Downgrade
  • TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration
  • TestAccSqlDatabaseInstance_EnableGoogleMlIntegration
  • TestAccSqlDatabaseInstance_FinalBackupConfig
  • TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork
  • TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess
  • TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess
  • TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
  • TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade
  • TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled
  • TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer
  • TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork
  • TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount
  • TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess
  • TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess
  • TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
  • TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade
  • TestAccSqlDatabaseInstance_RetainBackupOnDelete
  • TestAccSqlDatabaseInstance_Smt
  • TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate
  • TestAccSqlDatabaseInstance_SwitchoverSuccess
  • TestAccSqlDatabaseInstance_authNets
  • TestAccSqlDatabaseInstance_basicMSSQL
  • TestAccSqlDatabaseInstance_basicMSSQL_passwordWo
  • TestAccSqlDatabaseInstance_basicMSSQL_withEntraid
  • TestAccSqlDatabaseInstance_basic_with_user_labels
  • TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls
  • TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance
  • TestAccSqlDatabaseInstance_hyperdisk
  • TestAccSqlDatabaseInstance_includeReplicasForMajorVersionUpgrade
  • TestAccSqlDatabaseInstance_insights_enhanced_postgres17
  • TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance
  • TestAccSqlDatabaseInstance_performanceCaptureConfig
  • TestAccSqlDatabaseInstance_pscDnsConfig
  • TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable
  • TestAccSqlDatabaseInstance_settings_deletionProtection
  • TestAccSqlDatabaseInstance_settings_upgrade
  • TestAccSqlDatabaseInstance_switchTransactionLogsToCloudStorage
  • TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance
  • TestAccSqlDatabaseInstance_updateMCPEnabled
  • TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled
  • TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL
  • TestAccSqlDatabaseInstance_withPSCEnabled_updateAllowedConsumerProjects
  • TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange
  • TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange
  • TestAccSqlDatabase_instanceWithActivationPolicy
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
✅ Log TestAccBigQueryDataset_basic
✅ Log TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
✅ Log TestAccBigQueryDataset_collationUpdate
✅ Log TestAccBigQueryDataset_externalCatalogDatasetOptions_update
✅ Log TestAccCESTool_cesToolDataStoreToolEngineSourceBasicExample_update
✅ Log TestAccCESTool_cesToolPythonFunctionBasicExample_update
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
✅ Log TestAccDataSourceGoogleBackupDRBackupPlanAssociation_MultiRegion
✅ Log TestAccDataSourceGoogleBackupDRDataSourceReference_MultiRegion
✅ Log TestAccDataSourceGoogleBackupDRDataSourceReference_basic
✅ Log TestAccDataSourceGoogleBackupDRDataSourceReferences_basic
✅ Log TestAccProjectServiceListResource_queryIdentity
✅ Log TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig
✅ Log TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig
✅ Log TestAccSqlDatabaseInstance_AutoUpgradeEnabled
✅ Log TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize
✅ Log TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize
✅ Log TestAccSqlDatabaseInstance_Edition_Downgrade
✅ Log TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration
✅ Log TestAccSqlDatabaseInstance_EnableGoogleMlIntegration
✅ Log TestAccSqlDatabaseInstance_FinalBackupConfig
✅ Log TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork
✅ Log TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess
✅ Log TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess
✅ Log TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
✅ Log TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade
✅ Log TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled
✅ Log TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer
✅ Log TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork
✅ Log TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount
✅ Log TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess
✅ Log TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess
✅ Log TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
✅ Log TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade
✅ Log TestAccSqlDatabaseInstance_RetainBackupOnDelete
✅ Log TestAccSqlDatabaseInstance_Smt
✅ Log TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate
✅ Log TestAccSqlDatabaseInstance_SwitchoverSuccess
✅ Log TestAccSqlDatabaseInstance_authNets
✅ Log TestAccSqlDatabaseInstance_basicMSSQL
✅ Log TestAccSqlDatabaseInstance_basicMSSQL_passwordWo
✅ Log TestAccSqlDatabaseInstance_basicMSSQL_withEntraid
✅ Log TestAccSqlDatabaseInstance_basic_with_user_labels
✅ Log TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls
✅ Log TestAccSqlDatabaseInstance_hyperdisk
✅ Log TestAccSqlDatabaseInstance_includeReplicasForMajorVersionUpgrade
✅ Log TestAccSqlDatabaseInstance_insights_enhanced_postgres17
✅ Log TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance
✅ Log TestAccSqlDatabaseInstance_performanceCaptureConfig
✅ Log TestAccSqlDatabaseInstance_pscDnsConfig
✅ Log TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable
✅ Log TestAccSqlDatabaseInstance_settings_deletionProtection
✅ Log TestAccSqlDatabaseInstance_settings_upgrade
✅ Log TestAccSqlDatabaseInstance_switchTransactionLogsToCloudStorage
✅ Log TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance
✅ Log TestAccSqlDatabaseInstance_updateMCPEnabled
✅ Log TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled
✅ Log TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL
✅ Log TestAccSqlDatabaseInstance_withPSCEnabled_updateAllowedConsumerProjects
✅ Log TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange
✅ Log TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange
✅ Log TestAccSqlDatabase_instanceWithActivationPolicy
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for c69d94f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants