Skip to content

Migrate resource_compute_instance to new API - #18678

Draft
inadenenko wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
inadenenko:resource-compute-instance-migration-v3
Draft

Migrate resource_compute_instance to new API#18678
inadenenko wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
inadenenko:resource-compute-instance-migration-v3

Conversation

@inadenenko

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrate resource_compute_instance to REST

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ef2e9a3:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@inadenenko inadenenko closed this Aug 18, 2026
@inadenenko
inadenenko force-pushed the resource-compute-instance-migration-v3 branch from ef2e9a3 to 4014e22 Compare August 18, 2026 09:15
@inadenenko inadenenko reopened this Aug 18, 2026
@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4014e22:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 11 insertions(+), 11 deletions(-)
google-beta provider View Diff 2 files changed, 11 insertions(+), 11 deletions(-)
terraform-google-conversion View Diff 2 files changed, 7 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6907 6148 695 64
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 64 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_fullUpdate
  • TestAccComputeDisk_deleteDetach
  • TestAccComputeDisk_multiWriter
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
  • TestAccComputeInstanceFromMachineImage_basic
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromRegionTemplate_basic
  • TestAccComputeInstanceFromTemplateWithOverride_interface
  • TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceFromTemplate_IgmpQuery_v2
  • TestAccComputeInstanceFromTemplate_VSSWindows
  • TestAccComputeInstanceFromTemplate_basic
  • TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromTemplate_diskResourcePolicies
  • TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeInstanceFromTemplate_overrideAttachedDisk
  • TestAccComputeInstanceFromTemplate_overrideBootDisk
  • TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript
  • TestAccComputeInstanceFromTemplate_overrideScheduling
  • TestAccComputeInstanceFromTemplate_overrideScratchDisk
  • TestAccComputeInstanceFromTemplate_partnerMetadata
  • TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeInstanceFromTemplate_self_link_unique
  • TestAccComputeInstanceFromTemplate_useDiskSelfLink
  • TestAccComputeInstanceFromTemplate_workloadIdentity
  • TestAccComputeInstance_attachDisk_forceAttach
  • TestAccComputeInstance_attachedDisk
  • TestAccComputeInstance_attachedDiskUpdate
  • TestAccComputeInstance_attachedDisk_RSAencryption
  • TestAccComputeInstance_attachedDisk_modeRo
  • TestAccComputeInstance_attachedDisk_sourceUrl
  • TestAccComputeInstance_bootAndAttachedDisk_interface
  • TestAccComputeInstance_diskEncryption
  • TestAccComputeInstance_diskEncryptionRestart
  • TestAccComputeInstance_instanceEncryption
  • TestAccComputeInstance_internalIPv6PrefixLength
  • TestAccComputeInstance_kmsDiskEncryption
  • TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
  • TestAccComputeInstance_serviceAccountEmail_0scopes
  • TestAccComputeInstance_serviceAccount_updated
  • TestAccComputeInstance_serviceAccount_updated0to1to0scopes
  • TestAccComputeInstance_stopInstanceToUpdate
  • TestAccComputeInstance_subnetworkUpdate
  • TestAccComputeInstance_with375GbScratchDisk
  • TestAccComputeRegionDisk_deleteDetach
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataSourceComputeInstance_basic
  • TestAccDataSourceComputeInstance_networkAttachmentUsageExample
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSqlDatabaseInstance_performanceCaptureConfig
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log

@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6824280:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 622 insertions(+), 693 deletions(-)
google-beta provider View Diff 6 files changed, 760 insertions(+), 789 deletions(-)
terraform-google-conversion View Diff 2 files changed, 170 insertions(+), 12 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1557 1459 95 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 6824280!

@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6824280:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 622 insertions(+), 693 deletions(-)
google-beta provider View Diff 6 files changed, 760 insertions(+), 789 deletions(-)
terraform-google-conversion View Diff 2 files changed, 170 insertions(+), 12 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1557 1459 95 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 6824280!

@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 64c8419:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 650 insertions(+), 693 deletions(-)
google-beta provider View Diff 6 files changed, 788 insertions(+), 789 deletions(-)
terraform-google-conversion View Diff 2 files changed, 226 insertions(+), 12 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1557 1413 95 49
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 49 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeDisk_deleteDetach
  • TestAccComputeDisk_multiWriter
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeInstanceFromRegionTemplate_basic
  • TestAccComputeInstanceFromTemplateWithOverride_interface
  • TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceFromTemplate_IgmpQuery_v2
  • TestAccComputeInstanceFromTemplate_VSSWindows
  • TestAccComputeInstanceFromTemplate_basic
  • TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromTemplate_diskResourcePolicies
  • TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeInstanceFromTemplate_overrideAttachedDisk
  • TestAccComputeInstanceFromTemplate_overrideBootDisk
  • TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript
  • TestAccComputeInstanceFromTemplate_overrideScheduling
  • TestAccComputeInstanceFromTemplate_overrideScratchDisk
  • TestAccComputeInstanceFromTemplate_partnerMetadata
  • TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeInstanceFromTemplate_self_link_unique
  • TestAccComputeInstanceFromTemplate_useDiskSelfLink
  • TestAccComputeInstanceFromTemplate_workloadIdentity
  • TestAccComputeInstance_attachDisk_forceAttach
  • TestAccComputeInstance_attachedDisk
  • TestAccComputeInstance_attachedDiskUpdate
  • TestAccComputeInstance_attachedDisk_RSAencryption
  • TestAccComputeInstance_attachedDisk_modeRo
  • TestAccComputeInstance_attachedDisk_sourceUrl
  • TestAccComputeInstance_bootAndAttachedDisk_interface
  • TestAccComputeInstance_diskEncryption
  • TestAccComputeInstance_diskEncryptionRestart
  • TestAccComputeInstance_instanceEncryption
  • TestAccComputeInstance_internalIPv6PrefixLength
  • TestAccComputeInstance_kmsDiskEncryption
  • TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
  • TestAccComputeInstance_serviceAccountEmail_0scopes
  • TestAccComputeInstance_serviceAccount_updated
  • TestAccComputeInstance_serviceAccount_updated0to1to0scopes
  • TestAccComputeInstance_stopInstanceToUpdate
  • TestAccComputeInstance_subnetworkUpdate
  • TestAccComputeInstance_with375GbScratchDisk
  • TestAccComputeRegionDisk_deleteDetach
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataSourceComputeInstance_basic
  • TestAccDataSourceComputeInstance_networkAttachmentUsageExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeDisk_deleteDetach
✅ Log TestAccComputeDisk_multiWriter
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
✅ Log TestAccComputeInstanceFromRegionTemplate_basic
✅ Log TestAccComputeInstanceFromTemplateWithOverride_interface
✅ Log TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
✅ Log TestAccComputeInstanceFromTemplate_DiskForceAttach
✅ Log TestAccComputeInstanceFromTemplate_IgmpQuery_v2
✅ Log TestAccComputeInstanceFromTemplate_VSSWindows
✅ Log TestAccComputeInstanceFromTemplate_basic
✅ Log TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
✅ Log TestAccComputeInstanceFromTemplate_diskResourcePolicies
✅ Log TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
✅ Log TestAccComputeInstanceFromTemplate_overrideAttachedDisk
✅ Log TestAccComputeInstanceFromTemplate_overrideBootDisk
✅ Log TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript
✅ Log TestAccComputeInstanceFromTemplate_overrideScheduling
✅ Log TestAccComputeInstanceFromTemplate_overrideScratchDisk
✅ Log TestAccComputeInstanceFromTemplate_partnerMetadata
✅ Log TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
✅ Log TestAccComputeInstanceFromTemplate_self_link_unique
✅ Log TestAccComputeInstanceFromTemplate_useDiskSelfLink
✅ Log TestAccComputeInstanceFromTemplate_workloadIdentity
✅ Log TestAccComputeInstance_attachDisk_forceAttach
✅ Log TestAccComputeInstance_attachedDisk
✅ Log TestAccComputeInstance_attachedDiskUpdate
✅ Log TestAccComputeInstance_attachedDisk_RSAencryption
✅ Log TestAccComputeInstance_attachedDisk_modeRo
✅ Log TestAccComputeInstance_attachedDisk_sourceUrl
✅ Log TestAccComputeInstance_diskEncryption
✅ Log TestAccComputeInstance_diskEncryptionRestart
✅ Log TestAccComputeInstance_instanceEncryption
✅ Log TestAccComputeInstance_internalIPv6PrefixLength
✅ Log TestAccComputeInstance_kmsDiskEncryption
✅ Log TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
✅ Log TestAccComputeInstance_serviceAccountEmail_0scopes
✅ Log TestAccComputeInstance_serviceAccount_updated
✅ Log TestAccComputeInstance_serviceAccount_updated0to1to0scopes
✅ Log TestAccComputeInstance_stopInstanceToUpdate
✅ Log TestAccComputeInstance_subnetworkUpdate
✅ Log TestAccComputeInstance_with375GbScratchDisk
✅ Log TestAccComputeRegionDisk_deleteDetach
✅ Log TestAccDataSourceComputeInstance_basic
✅ Log TestAccDataSourceComputeInstance_networkAttachmentUsageExample
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstance_bootAndAttachedDisk_interface
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 64c8419!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants