Skip to content

remove deprecated interconnect_attachment_group.attachment - #18676

Open
c2thorn wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-interconnect-attachment-group-attachment
Open

remove deprecated interconnect_attachment_group.attachment#18676
c2thorn wants to merge 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-interconnect-attachment-group-attachment

Conversation

@c2thorn

@c2thorn c2thorn commented Aug 17, 2026

Copy link
Copy Markdown
Member

Removes the deprecated attachment attribute from google_compute_interconnect_attachment_group (replaced by attachments).

Fixes hashicorp/terraform-provider-google#27532

compute: removed deprecated `attachment` from `google_compute_interconnect_attachment_group`

@modular-magician

modular-magician commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3c0dc78:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 6 insertions(+), 25 deletions(-)
google-beta provider View Diff 4 files changed, 6 insertions(+), 25 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field logical_structure.regions.metros.facilities.zones.attachment within resource google_compute_interconnect_attachment_group was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1557 1460 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for 3c0dc78!

@c2thorn

c2thorn commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

test failures are not related

@c2thorn

c2thorn commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from SirGitsalot August 17, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants