networkconnectivity: add auto_accept_hub to google_network_connectivity_spoke - #18666
Open
AzySir wants to merge 2 commits into
Open
networkconnectivity: add auto_accept_hub to google_network_connectivity_spoke#18666AzySir wants to merge 2 commits into
AzySir wants to merge 2 commits into
Conversation
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
auto_accept_hubtogoogle_network_connectivity_spoke.When true, after the spoke is created the provider calls
hubs.acceptSpokeif the spoke is stillINACTIVE. After an update that needs hub approval, it callshubs.acceptSpokeUpdate. This is for cross-project spokes when the same credentials can accept on the hub.Same-project spokes are already accepted by the API. If the spoke apply cannot accept on the hub, leave this unset and accept from the hub project (
google_network_connectivity_hub_spoke_acceptance).