Feat/add network connectivity hub spoke acceptance - #18665
Open
AzySir wants to merge 2 commits into
Open
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#27458
Part of hashicorp/terraform-provider-google#17109
Adds
google_network_connectivity_hub_spoke_acceptanceso a hub admin can accept a cross-project NCC spoke (acceptSpoke) and later accept spoke updates (acceptSpokeUpdate) without maintainingauto_accept_projects.The issue sketched
spokes = [...]. This is one spoke per resource; usefor_eachfor several. Same-project spokes are still auto-accepted by the API.Create calls
hubs.acceptSpoke. Settingspoke_etagto the spoke's etag accepts a pending update. Destroy callshubs.rejectSpoke.google_network_connectivity_spokenow exportsetag.The generated acceptance test creates a second project and is
skip_vcr. It needsGOOGLE_ORGandGOOGLE_BILLING_ACCOUNTif run live.