Skip to content

Feat/add network connectivity hub spoke acceptance - #18665

Open
AzySir wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
AzySir:feat/add-network-connectivity-hub-spoke-acceptance
Open

Feat/add network connectivity hub spoke acceptance#18665
AzySir wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
AzySir:feat/add-network-connectivity-hub-spoke-acceptance

Conversation

@AzySir

@AzySir AzySir commented Aug 15, 2026

Copy link
Copy Markdown

Fixes hashicorp/terraform-provider-google#27458

Part of hashicorp/terraform-provider-google#17109

Adds google_network_connectivity_hub_spoke_acceptance so a hub admin can accept a cross-project NCC spoke (acceptSpoke) and later accept spoke updates (acceptSpokeUpdate) without maintaining auto_accept_projects.

The issue sketched spokes = [...]. This is one spoke per resource; use for_each for several. Same-project spokes are still auto-accepted by the API.

Create calls hubs.acceptSpoke. Setting spoke_etag to the spoke's etag accepts a pending update. Destroy calls hubs.rejectSpoke. google_network_connectivity_spoke now exports etag.

The generated acceptance test creates a second project and is skip_vcr. It needs GOOGLE_ORG and GOOGLE_BILLING_ACCOUNT if run live.

`google_network_connectivity_hub_spoke_acceptance`
networkconnectivity: added `etag` field to `google_network_connectivity_spoke` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 15, 2026
@github-actions
github-actions Bot requested a review from SirGitsalot August 15, 2026 22:00
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Resource Request] google_network_connectivity_hub_spoke_acceptance - accepting spoke connections to ncc hub

2 participants