fix(chronicle): fix permadiff on chronicle_feed sensitive auth fields - #18662
Open
vr-ibm wants to merge 1 commit into
Open
fix(chronicle): fix permadiff on chronicle_feed sensitive auth fields#18662vr-ibm wants to merge 1 commit into
vr-ibm wants to merge 1 commit into
Conversation
Add ignore_read: true to all sensitive authentication fields in Feed.yaml to prevent perpetual diffs when the Chronicle API omits write-only credentials on read. The Chronicle API never echoes back secrets, passwords, private keys, and access keys after create/update. Without ignore_read, the generated flatten functions return nil for these fields, causing Terraform to see a diff on every plan even when no changes were made. Fixes: hashicorp/terraform-provider-google#28314
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a07fe4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @vr-ibm, @ankitgoyal0301 VCR tests complete for 8a07fe4! |
vr-ibm
marked this pull request as ready for review
August 15, 2026 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashicorp/terraform-provider-google#28314
Adds
ignore_read: trueto all sensitive authentication fields inFeed.yamlto prevent perpetual diffs when the Chronicle API omits write-only credentials on read.Details
ignore_read: trueto 77 sensitive authentication fields across allgoogle_chronicle_feedsettings blocksazure_ad_audit_settings,amazon_sqs_v2_settings,sftp_settings,azure_blob_store_v2_settings, and many moreRelease Note Template for Downstream PRs (will be copied)