Skip to content

Fixed WAF config tests - #18655

Open
augustoscit wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
augustoscit:fix-waf-config-tests-in-compute-security-policy
Open

Fixed WAF config tests#18655
augustoscit wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
augustoscit:fix-waf-config-tests-in-compute-security-policy

Conversation

@augustoscit

@augustoscit augustoscit commented Aug 14, 2026

Copy link
Copy Markdown

Fixes Pre configured WAF tests that were failing due to recent backend changes (lack of http status on deny action)

Updates tests:

TestAccComputeSecurityPolicyRule_withPreconfiguredWafConfig
TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
TestAccComputeRegionSecurityPolicyRule_withPreconfiguredWafConfig
TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithRulesPreconfiguredWafConfig
TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithRulesBasicUpdate
TestAccComputeRegionSecurityPolicy_regionSecurityPolicyRuleOrderingWithMultipleRules

Fixes: 28048

Fixes: 28475

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixes pre configured waf tests in `google_compute_region_security_policy`
compute: fixes pre configured waf tests in `google_compute_region_security_policy_rule`
compute: fixes pre configured waf tests in `google_compute_security_policy`
compute: fixes pre configured waf tests in `google_compute_security_policy_rule`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 14, 2026
@google-cla

google-cla Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…cyWithRulesBasicUpdate and TestAccComputeRegionSecurityPolicy_regionSecurityPolicyRuleOrderingWithMultipleRules
@augustoscit
augustoscit marked this pull request as ready for review August 17, 2026 20:11
@github-actions
github-actions Bot requested a review from ScottSuarez August 17, 2026 20:12
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeSecurityPolicy_withPreconfiguredWafConfig Failing test(s): TestAccComputeSecurityPolicyRule_withPreconfiguredWafConfig

2 participants