Skip to content

storage: add crc32c verification for object content - #18648

Draft
gurusai-voleti wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:issue_532850232
Draft

storage: add crc32c verification for object content#18648
gurusai-voleti wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:issue_532850232

Conversation

@gurusai-voleti

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added crc32c verification for data `google_storage_bucket_object_content`

@modular-magician

modular-magician commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 474d291:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 135 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 135 insertions(+), 5 deletions(-)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccDataSourceStorageBucketObjectContent_Crc32cMismatch

Analytics

Total Tests Passed Skipped Affected
137 121 12 4
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataSourceStorageBucketObjectContent_Basic
  • TestAccDataSourceStorageBucketObjectContent_Issue15717
  • TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility
  • TestAccStorageObject_knownAfterApply

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataSourceStorageBucketObjectContent_Basic
✅ Log TestAccDataSourceStorageBucketObjectContent_Issue15717
✅ Log TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility
✅ Log TestAccStorageObject_knownAfterApply

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @sameer-google VCR tests complete for 474d291!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants