Skip to content

Mark backup_plan_association_id immutable - #18647

Open
Megha-Bose wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:fix/backupdr-bpa-immutable-1786687525
Open

Mark backup_plan_association_id immutable#18647
Megha-Bose wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:fix/backupdr-bpa-immutable-1786687525

Conversation

@Megha-Bose

@Megha-Bose Megha-Bose commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This change marks the backup_plan_association_id parameter as immutable so Terraform will force replacement instead of in-place updates.

manual runs

backupdr: mark backup plan association id immutable

@google-cla

google-cla Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
github-actions Bot requested a review from melinath August 14, 2026 06:42
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@Megha-Bose
Megha-Bose force-pushed the fix/backupdr-bpa-immutable-1786687525 branch from 9200f3c to 95cd518 Compare August 14, 2026 06:59
@modular-magician

modular-magician commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9200f3c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
37 24 13 0
Affected Service Packages
  • backupdr

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@Megha-Bose, @melinath VCR tests complete for 9200f3c!

@modular-magician

modular-magician commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 95cd518:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
37 24 13 0
Affected Service Packages
  • backupdr

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@Megha-Bose, @melinath VCR tests complete for 95cd518!

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re currently requesting a change in process for Googlers (or individuals on behalf of Googlers) contributing changes to the Terraform Provider for Google Cloud. Please see go/terraform-ssp-adjustment for details.

test_env_vars:
project: PROJECT_NAME
parameters:
- name: location

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location should probably also be immutable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants