Mark backup_plan_association_id immutable - #18647
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
9200f3c to
95cd518
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9200f3c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @Megha-Bose, @melinath VCR tests complete for 9200f3c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 95cd518: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @Megha-Bose, @melinath VCR tests complete for 95cd518! |
melinath
left a comment
There was a problem hiding this comment.
We’re currently requesting a change in process for Googlers (or individuals on behalf of Googlers) contributing changes to the Terraform Provider for Google Cloud. Please see go/terraform-ssp-adjustment for details.
| test_env_vars: | ||
| project: PROJECT_NAME | ||
| parameters: | ||
| - name: location |
There was a problem hiding this comment.
location should probably also be immutable
This change marks the backup_plan_association_id parameter as immutable so Terraform will force replacement instead of in-place updates.
manual runs