fix(storage): resolve race condition in compose object test - #3344
Merged
krishnamd-jkp merged 3 commits intoAug 19, 2026
Merged
krishnamd-jkp merged 3 commits into
krishnamd-jkp merged 3 commits into
Conversation
- Use an isolated bucket in ChangeDefaultStorageClassTest to prevent modifying the default storage class of the shared BucketNameGeneric bucket, eliminating test flakiness and mixed-storage-class compose errors in ComposeObjectTest. Fixes GoogleCloudPlatform#2038
product-auto-label
Bot
added
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ChangeDefaultStorageClass test to use a dedicated, temporary bucket instead of a shared generic bucket, enabling safer concurrent test execution. The review feedback highlights a potential race condition in StorageFixture when creating buckets concurrently due to non-thread-safe list operations, and suggests removing the redundant step of reverting the storage class back to standard since the temporary bucket is registered for deletion.
krishnamd-jkp
previously approved these changes
Aug 17, 2026
krishnamd-jkp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
krishnamd-jkp
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
krishnamd-jkp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
krishnamd-jkp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
krishnamd-jkp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Increases test execution timeout to 20 minutes to prevent intermittent timeouts in Kokoro CI test runs.
krishnamd-jkp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
krishnamd-jkp
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides fix to the issue.
The flake occurred because
ChangeDefaultStorageClassTestwas changing the storage class of the shared bucketBucketNameGenerictoCOLDLINE. WhenComposeObjectTestran concurrently, it failed with aBadRequestbecause it attempted to compose objects with mixed storage classes (StandardvsColdline).This change has removed a shared bucket
BucketNameGenericused in theChangeDefaultStorageClassTestand introduced isolated bucket in theChangeDefaultStorageClassTestto prevent modifying the default storage class of the sharedBucketNameGenericbucket, eliminatingtest flakiness due to mixed-storage-class compose errors in
ComposeObjectTest