Bug Fix: Resolved issue with Academic Form submissions#44
Open
JeremyCaney wants to merge 1 commit into
Open
Conversation
The recently introduced `Province` field (789d3d6) is optional, and only supported on the Demo and Trial Request forms. But the underlying `Contact` is used elsewhere. That's fine unless you try to (re)use the binding model as a mapping model with the `ReverseTopicMappingService`, in which case it will fail to find the corresponding value. The fix? Disable mapping for this field. Long-term we need to rethink this structure. For now, however, this is a sufficient solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently introduced
Provincefield (789d3d6) is optional, and only supported on the Demo and Trial Request forms. But the underlyingContactis used elsewhere. That's fine unless you try to (re)use the binding model as a mapping model with theReverseTopicMappingService, in which case it will fail to find the corresponding value. The fix? Disable mapping for this field.Long-term we need to rethink this structure. For now, however, this is a sufficient solution, and most importantly mitigates the bug.